This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Preserve license info in ship edit #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccampbell
approved these changes
Jun 12, 2019
laverya
force-pushed
the
preserve-license-info-in-ship-edit
branch
from
72515d1
to
9660636
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Improved the function that converts a saved ship state into an app release for
ship editAdded an integration test covering this functionality
This resolves #960.
How I Did it
How to verify it
Observe that the newly added integration test fails the
ship editcomponent prior to the code changes in the second commit.Description for the Changelog
ship editof replicated.app upstreams properly includes app license infoPicture of a Ship (not required but encouraged)