Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Error with proxied images: No 'Authorization' header provided in request #889

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

divolgin
Copy link
Member

What I Did

Fixed error handling and error messaging for proxied private images when those images do not exist in the private registry.

How I Did it

Added handling for "not found" error and removed the unauthenticated pull attempt.

How to verify it

Add a bogus image to assets (linked registry must be setup properly for this), such as

    - docker:
        image: myorg/myimage:latestest
        source: gcr
        dest: docker/myimage:latestest.tar

Error should read

Error response from daemon: manifest for myimage:latestest not found

Instead of

unauthorized: No 'Authorization' header provided in request

Description for the Changelog

Better user messaging when specified images do not exist in the private registry.

Picture of a Ship (not required but encouraged)

Copy link
Member

@dexhorthy dexhorthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one suggestion

@divolgin divolgin changed the title [ch19487] Error with proxied images: No 'Authorization' header provided in request Error with proxied images: No 'Authorization' header provided in request Mar 27, 2019
@divolgin divolgin merged commit 6dd9032 into replicatedhq:master Mar 27, 2019
@divolgin divolgin deleted the ch19487 branch April 12, 2019 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants