This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
templating: fallbacks to ease migration from console-flavored ship #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I Did
------------
- In `{{repl Installation "installation_id"}}, if `license_id` was used to fetch, template in the license id value
- In `{{repl Installation "license_id"}}, if `installation_id` was used to fetch, template in the installation id value
- Add `{{repl LicenseFieldValue "FIELD_KEY"}} as an alias for `{{repl EntitlementValue "FIELD_KEY"}}
How to verify it
------------
- ship init replicated.app/slug?license_id=..., ensure `{{repl
Installation "installation_id"}} emits the given license ID.
and so on
Description for the Changelog
------------
- In `{{repl Installation "installation_id"}}, if `license_id` was used to fetch, template in the license id value
- In `{{repl Installation "license_id"}}, if `installation_id` was used to fetch, template in the installation id value
- Add `{{repl LicenseFieldValue "FIELD_KEY"}} as an alias for `{{repl EntitlementValue "FIELD_KEY"}}
dexhorthy
commented
Mar 26, 2019
| level.Debug(ctx.Logger).Log("event", "EntitlementValue.empty") | ||
| return "" | ||
| } | ||
| func (ctx *InstallationContext) entitlementValue(name string) string { |
There was a problem hiding this comment.
weird whitespace things happening here because I pulled this up to a standalone function instead of inline.
|
Nice. Since "installation_id" and "license_id" are actually the same value, this is good. The work we did to rename the field should have left the old names as alias. Thanks for adding! |
marccampbell
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
{{repl Installation "installation_id"}}, iflicense_idwas used to fetch, template in the license id value{{repl Installation "license_id"}}, ifinstallation_idwas used to fetch, template in the installation id value{{repl LicenseFieldValue "FIELD_KEY"}}as an alias for `{{repl EntitlementValue "FIELD_KEY"}}How to verify it
Installation "installation_id"}} emits the given license ID.
and so on
Description for the Changelog
{{repl Installation "installation_id"}}, iflicense_idwas used to fetch, template in the license id value{{repl Installation "license_id"}}, ifinstallation_idwas used to fetch, template in the installation id value{{repl LicenseFieldValue "FIELD_KEY"}}as an alias for{{repl EntitlementValue "FIELD_KEY"}}