This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Grayson/render markdown links #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://github.com/avatars/in/9403?s=60&v=4){kind=small}
| @@ -44,7 +45,17 @@ export default class ConfigCheckbox extends React.Component { | |||
| <span className="field-label recommended">Recommended</span> : | |||
| null} | |||
| </label> | |||
| {this.props.help_text !== "" ? <p className="field-section-help-text u-marginTop--small u-lineHeight--normal u-marginLeft--small">{this.props.help_text}</p> : null} | |||
| {this.props.help_text !== "" ? | |||
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
sgalsaleh
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Added markdown styling to config item help texts.
How I Did it
Wrapped
help_textof various config items in a<Markdown>component so that links and other styles will be rendered.How to verify it
Create a config item that contains a link in the
help_text. That should be rendered as a clickable link when viewing the rendered version of the config.Description for the Changelog
Fix some config items types not rendering help text as markdown making links not clickable.
Picture of a Ship (not required but encouraged)