Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

pkg/lifecycle/kubectl: Fix swallowed error on DaemonlessKubectl.Execute #1053

Merged
merged 1 commit into from
Aug 27, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/lifecycle/kubectl/daemonless.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ func (d *DaemonlessKubectl) Execute(ctx context.Context, release api.Release, st
debug := level.Debug(log.With(d.Logger, "step.type", "kubectl"))

cmd, err := d.prepareCmd(release, step)
if err != nil {
return errors.Wrap(err, "failed to prepare command for daemonless kubectl execution")
}

debug.Log("event", "kubectl.execute", "args", fmt.Sprintf("%+v", cmd.Args))

var stderr bytes.Buffer
Expand Down