Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Replay browser to exit before starting a new recording #496

Merged
merged 3 commits into from
May 28, 2024

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 28, 2024

@bvaughn bvaughn requested a review from Andarist May 28, 2024 11:41
Copy link

changeset-bot bot commented May 28, 2024

🦋 Changeset detected

Latest commit: 3111da5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
replayio Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,5 @@
---
"replayio": minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is debatable I guess.

Copy link

replay-io bot commented May 28, 2024

Status Complete ↗︎
Commit b4f6259
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • Comment on lines +41 to +44
    const confirmed = await confirm(
    "The replay browser is already running. You'll need to close it before starting a new recording.\n\nWould you like to close it now?",
    true
    );
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'm a little bit conflicted on this proposed behavior but when thinking about it logically... yee, why wouldn't we want to help the user and do it for them if we can? It definitely sounds reasonable. So you have my 👍

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I felt the same. I didn't intend to do it, but then I thought I probably should

    @bvaughn bvaughn merged commit 52646e3 into main May 28, 2024
    7 checks passed
    @bvaughn bvaughn deleted the require-exit-browser-before-record branch May 28, 2024 14:33
    @github-actions github-actions bot mentioned this pull request May 28, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants