replay: add attach flag to launch command (#246)

* replay: add detached flag to launch command

Fixes BAC-3976

* s/detach/attach

* fix formatting

* swap order of arguments

* swap invocation too

---------

Co-authored-by: Ryan Duffy <ryan@replay.io>

packages/replay/src/bin.ts

@@ -64,6 +64,11 @@ commandWithGlobalOptions("upload <id>")
 commandWithGlobalOptions("launch [url]")
   .description("Launch the replay browser")
   .option("-b, --browser <browser>", "Browser to launch", "chromium")
+  .option(
+    "--attach <true|false>",
+    "Whether to attach to the browser process after launching",
+    false
+  )
   .allowUnknownOption()
   .action(commandLaunchBrowser);
 
@@ -188,15 +193,20 @@ async function commandUploadRecording(id: string, opts: CommandLineOptions) {
 
 async function commandLaunchBrowser(
   url: string | undefined,
-  opts: Pick<CommandLineOptions, "warn"> & { browser: string | undefined }
+  opts: Pick<CommandLineOptions, "warn"> & {
+    browser: string | undefined;
+    attach: boolean | undefined;
+  }
 ) {
   try {
     debug("Options", opts);
 
     const browser = fuzzyBrowserName(opts.browser) || "chromium";
     assertValidBrowserName(browser);
 
-    await launchBrowser(browser, [url || "about:blank"]);
+    const attach = opts.attach || false;
+
+    await launchBrowser(browser, [url || "about:blank"], attach);
     process.exit(0);
   } catch (e) {
     console.error("Failed to launch browser");

packages/replay/src/main.ts

@@ -730,7 +730,11 @@ async function updateMetadata({
   }
 }
 
-async function launchBrowser(browserName: BrowserName, args: string[] = []) {
+async function launchBrowser(
+  browserName: BrowserName,
+  args: string[] = [],
+  attach: boolean = false
+) {
   const execPath = getExecutablePath(browserName);
   if (!execPath) {
     throw new Error(`${browserName} not supported on the current platform`);
@@ -750,7 +754,7 @@ async function launchBrowser(browserName: BrowserName, args: string[] = []) {
     firefox: ["-foreground", ...args],
   };
 
-  const proc = spawn(execPath, browserArgs[browserName], { detached: true });
+  const proc = spawn(execPath, browserArgs[browserName], { detached: !attach });
   proc.unref();
 
   return proc;