Close the launched browser on Ctrl+C when recording (#500)

replayio · May 28, 2024 · 1740c99 · 1740c99
1 parent a243633
commit 1740c99
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/.changeset/serious-coins-mate.md b/.changeset/serious-coins-mate.md
@@ -0,0 +1,5 @@
+---
+"replayio": patch
+---
+
+The launched browser will now get correctly closed on Ctrl+C when recording
diff --git a/packages/replayio/src/utils/browser/launchBrowser.ts b/packages/replayio/src/utils/browser/launchBrowser.ts
@@ -60,6 +60,9 @@ export async function launchBrowser(
 
         prompt({
           signal: abortControllerForPrompt.signal,
+          onExit: () => {
+            spawnDeferred.data.kill();
+          },
         }).then(() => {
           spawnDeferred.data.kill();
         });

diff --git a/packages/replayio/src/utils/prompt/prompt.ts b/packages/replayio/src/utils/prompt/prompt.ts
@@ -1,6 +1,8 @@
 export async function prompt({
+  onExit,
   signal,
 }: {
+  onExit?: () => void;
   signal?: AbortSignal;
 } = {}): Promise<boolean> {
   return new Promise(resolve => {
@@ -38,6 +40,7 @@ export async function prompt({
         case "\x03":
           // \x03 is Ctrl+C (aka "End of text")
           // https://donsnotes.com/tech/charsets/ascii.html
+          onExit?.();
           process.exit(0);
         default:
           resolve(false);