Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch meta e2e tests from breakpoints-02 to logpoints-01 #10603

Merged
merged 2 commits into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ You'll also probably need to specifically share that recording as "Public", espe

We use 1 specific Playwright test recording which is a replay of the breakpoints-05 test from this repo. Similar to the instructions above, to update this to a more recent version, you can visit the dashboard for FE E2E Tests and select a more recent recording ID for that test.

We also now have a "golden recording" of one of our own `breakpoints-02` E2E test runs. This serves as a testbed for checking more advanced behaviors like the React and Redux routines. If we ever need to update this, just copy-paste the recording ID from a test run in our "Frontend E2E tests" workspace.
We also now have a "golden recording" of one of our own `logpoints-01` E2E test runs. This serves as a testbed for checking more advanced behaviors like the React and Redux routines. If we ever need to update this, just copy-paste the recording ID from a test run in our "Frontend E2E tests" workspace.

### Test Suite Dashboard Tests

Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/examples.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/e2e-tests/tests/jump-to-code-02_redux-j2c.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import { getByTestName, waitFor } from "../helpers/utils";
import test from "../testFixture";

// trunk-ignore(gitleaks/generic-api-key)

Check warning on line 10 in packages/e2e-tests/tests/jump-to-code-02_redux-j2c.test.ts

View workflow job for this annotation

GitHub Actions / Trunk Check

trunk(ignore-does-nothing)

[new] trunk-ignore(gitleaks/generic-api-key) is not suppressing a lint issue
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

async function checkForJumpButton(actionListItem: Locator, shouldBeEnabled: boolean) {
const jumpButton = getEventJumpButton(actionListItem);
Expand Down Expand Up @@ -90,8 +90,8 @@
await closeSource(page, "SourcesTree.tsx");

// Inside of an adapter that passes dispatch-wrapped actions to <QuickOpenModal>
// This is also one tick off, but should still _display_ as "1/3"
// This is also one tick off, but should still _display_ as "1/10"
jumpToReduxDispatch(page, "quickOpen/setQuickOpenQuery");
await verifyJumpToCodeResults(page, "QuickOpenModal.tsx", 551, { current: 1, total: 3 });
await verifyJumpToCodeResults(page, "QuickOpenModal.tsx", 551, { current: 1, total: 10 });
await closeSource(page, "QuickOpenModal.tsx");
});
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
const sourceUrl = "react-dom.production.js";
const lineNumber = 150;

// trunk-ignore(gitleaks/generic-api-key)

Check warning on line 18 in packages/e2e-tests/tests/logpoints-10_too_many_points_to_find.test.ts

View workflow job for this annotation

GitHub Actions / Trunk Check

trunk(ignore-does-nothing)

[new] trunk-ignore(gitleaks/generic-api-key) is not suppressing a lint issue
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

test(`logpoints-10: too-many-points-to-find UX`, async ({
pageWithMeta: { page, recordingId, testScope },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
import test, { expect } from "../testFixture";

// We need 500...10k hits
// Line 301 has 534 hits
// Line 12196 has 4.4k hits
const sourceUrl = "react-dom.production.js";
const lineNumber = 301;
const lineNumber = 12196;

// trunk-ignore(gitleaks/generic-api-key)

Check warning on line 18 in packages/e2e-tests/tests/logpoints-11_too_many_points_to_run_analysis.test.ts

View workflow job for this annotation

GitHub Actions / Trunk Check

trunk(ignore-does-nothing)

[new] trunk-ignore(gitleaks/generic-api-key) is not suppressing a lint issue
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

test(`logpoints-11: too-many-points-to-run-analysis UX`, async ({
pageWithMeta: { page, recordingId, testScope },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
import test, { expect } from "../testFixture";

// Why is this even getting confused as an API key?
// trunk-ignore(gitleaks/generic-api-key)

Check warning on line 19 in packages/e2e-tests/tests/react_devtools-02-integrations.test.ts

View workflow job for this annotation

GitHub Actions / Trunk Check

trunk(ignore-does-nothing)

[new] trunk-ignore(gitleaks/generic-api-key) is not suppressing a lint issue
test.use({ exampleKey: "breakpoints-02" });
test.use({ exampleKey: "logpoints-01" });

test("react_devtools-02: RDT integrations (Chromium)", async ({
pageWithMeta: { page, recordingId, testScope },
Expand All @@ -32,7 +32,7 @@

await openDevToolsTab(page);

await warpToMessage(page, "Waiting for breakpoint at doc_rr_basic.html:21 (waitForBreakpoint)");
await warpToMessage(page, "Waiting for breakpoint at doc_rr_basic.html:20 (waitForBreakpoint)");

// If the "React" tab shows up, we know that the routine ran
await openReactDevtoolsPanel(page);
Expand Down
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Tests are defined in the `manifest.js` file.
// Example browser based e2e tests
{
"example": "doc_rr_basic.html",
"script": "breakpoints-02.js",
"script": "logpoints-01.js",
"targets": ["gecko", "chromium"]
},

Expand Down
Loading