Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MUI v5 for React 18 / 19 compat #113

Merged
merged 51 commits into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. build: yarn add @mui/material @mui/styles ; yarn add @mui/lab ; yarn …

    …add @mui/icons-material
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cbfcc75 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a9b0741 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f3b5ead View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cf6a8de View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e1a5ae6 View commit details
    Browse the repository at this point in the history
  6. build: yarn add @mui/material @mui/styles ; yarn add @mui/lab ; yarn …

    …add @mui/icons-material
    
    # Conflicts:
    #	yarn.lock
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f4854d4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    20518ff View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    99379c1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fb556b8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    619d199 View commit details
    Browse the repository at this point in the history
  11. fix: Two tabs problems:

    First, the color changes indicated at https://mui.com/material-ui/migration/v5-component-changes/#update-default-indicatorcolor-and-textcolor-prop-values
    
    Second, remove the the trailing "px" a number rather than string when passing values to the react-virtualized List component.  See
    https://mui.com/material-ui/migration/v5-style-changes/\#%E2%9C%85-remove-px-suffix
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a4972bb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    51f4092 View commit details
    Browse the repository at this point in the history
  13. fix: indirection of onChange prop of Slider via ownerState

    this was causing the slider-based cypress tests to fail.
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    975c6d0 View commit details
    Browse the repository at this point in the history
  14. fix: remove zIndex from AppBar to fix drawer issue

    appBar was still over the date picker in mobile screen size, failing one of the cypress:run:mobile tests.  See also
    https://mui.com/material-ui/migration/v5-component-changes/\#fix-z-index-issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ce9ec97 View commit details
    Browse the repository at this point in the history
  15. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/containers

    followed by lint fixes and manual review
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    300930f View commit details
    Browse the repository at this point in the history
  16. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Ba…

    …nkAccountForm.tsx
    
    linting and review
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d922bfe View commit details
    Browse the repository at this point in the history
  17. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Co…

    …mmentForm.tsx
    
    review, lint
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    85f0481 View commit details
    Browse the repository at this point in the history
  18. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Ma…

    …inLayout.tsx
    
    review, remove class for root and use ampersand instead, adding a flexGrow:1 to get styling as before
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4137f68 View commit details
    Browse the repository at this point in the history
  19. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Na…

    …vBar.tsx,
    
    review, appBarShift was incorrectly considered a child of root; fixed that with removal of space between & and ., lint
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    91d7793 View commit details
    Browse the repository at this point in the history
  20. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Na…

    …vDrawer.tsx
    
    review, lint, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d9262eb View commit details
    Browse the repository at this point in the history
  21. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/No…

    …tificationListItem.tsx
    
    review, lint, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ca957ff View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    c2c051b View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    7c43217 View commit details
    Browse the repository at this point in the history
  24. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Sk…

    …eletonList.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b5ca05f View commit details
    Browse the repository at this point in the history
  25. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionAmount.tsx
    
    lint, remove space between & and . because classes are conditionally applied
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    fef8773 View commit details
    Browse the repository at this point in the history
  26. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionCreateStepOne.tsx
    
    lint and review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    08cf585 View commit details
    Browse the repository at this point in the history
  27. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionCreateStepTwo.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    97009e2 View commit details
    Browse the repository at this point in the history
  28. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionCreateStepThree.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6f0441a View commit details
    Browse the repository at this point in the history
  29. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionDateRangeFilter.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c325b24 View commit details
    Browse the repository at this point in the history
  30. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionDetail.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    004ba3e View commit details
    Browse the repository at this point in the history
  31. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionItem.tsx
    
    lint, review, problems with SmallAvatar, fixed manually
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    81981f6 View commit details
    Browse the repository at this point in the history
  32. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionList.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    eea3cb9 View commit details
    Browse the repository at this point in the history
  33. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionListAmountRangeFilter.tsx
    
    lint, review, did not work really at all, fixed by using sx prop rather than classes at all
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8f9d8b3 View commit details
    Browse the repository at this point in the history
  34. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionListFilters.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    da55283 View commit details
    Browse the repository at this point in the history
  35. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr…

    …ansactionTitle.tsx
    
    lint, review, no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    66f6009 View commit details
    Browse the repository at this point in the history
  36. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Us…

    …erSettingsForm.tsx
    
    lint, review, form did not want to play nice with classes, fixed with sx for submit button and styled wrapping div for form
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b74d32c View commit details
    Browse the repository at this point in the history
  37. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components

    had apparently accidentally failed-to-checkin TransactionInfiniteList and userSearchForm, but both were reviewed and had no issues
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0121063 View commit details
    Browse the repository at this point in the history
  38. build: yarn remove @mui/styles and some

    minor style fixups to be rid of the dependency causing the peer dependency warning
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    aacb126 View commit details
    Browse the repository at this point in the history
  39. chore: update RWA to make running locally easier (cypress-io#1524)

    * chore: fix typings issues from yarn start when starting the backend dev server
    
    * reseed data as test shouldnt fail for new users
    
    * fix aws exports not failing RWA if missing
    
    * use @cypress/vite-dev-server to use different port from app so users can go between e2e and ct at the same time
    
    * fix types
    
    * run prettier
    
    * fix unit tests
    
    * fix linting issue by breaking chainable up
    AtofStryker authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    82af097 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    8138617 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    dc5dae5 View commit details
    Browse the repository at this point in the history
  42. chore(deps): update dependency express to version 4.19.2 🌟 (cypress-i…

    …o#1535)
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cf49cad View commit details
    Browse the repository at this point in the history
  43. chore(deps): update dependency cypress to version 13.7.2 🌟 (cypress-i…

    …o#1538)
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9b2d572 View commit details
    Browse the repository at this point in the history
  44. chore(deps): update cypress to 13.7.3 🌟 (cypress-io#1543)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c24b856 View commit details
    Browse the repository at this point in the history
  45. build: remove @ts-expect-error annotations no longer used after yarn.…

    …lock
    
    merge resolution
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e059d98 View commit details
    Browse the repository at this point in the history
  46. test: issue 1278 re-enabling test that had failed on firefox,

    which is not failing after the upgrade to MUI v5.  See
    cypress-io#1278
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d4bd582 View commit details
    Browse the repository at this point in the history
  47. build: replace express-graphql with graphql-http and graphql-playgrou… (

    cypress-io#1521)
    
    * build: replace express-graphql with graphql-http and graphql-playground-middleware-express
    
    toward resolution of issue cypress-io#1420 and cypress-io#1508
    
    * fix: go ahead and preempt provision of GET at /graphql by graphql-http
    
    with graphql-playground-middleware-express, rather than serving it from GET /gql-playground. This preserves functionality closer to as it was with express-graphql.
    
    * fix: whoops did not mean to modify database.json
    
    * Update backend/app.ts
    
    Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com>
    
    * style: do not pollute type system with one-off inline types
    
    * fix: consume rename commited on github from reviewer suggestion
    
    * style: do not pollute Query.ts either with one-off inline types
    
    * build: empty commit to clear perhaps spurious circleCI failure on firefox
    
    all specs passing on firefox locally.
    
    ---------
    
    Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com>
    2 people authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a2b7f05 View commit details
    Browse the repository at this point in the history
  48. fix: unset flex-direction which is newly set to row-reverse for

    AvatarGroup in mui5.
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    efc8876 View commit details
    Browse the repository at this point in the history
  49. fix: undo parent commit fix because avatars were backward and

    no longer overlapping.  Instead eat up space to right of avatars.
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f2f03dc View commit details
    Browse the repository at this point in the history
  50. fix: get body font size back down to 14, establish knobs for

    modifying input styles
    timheilman authored and markerikson committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    72061cf View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    3bdceb9 View commit details
    Browse the repository at this point in the history