Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: identity caching + metrics #197

Merged
merged 31 commits into from
Jun 26, 2023
Merged

feat: identity caching + metrics #197

merged 31 commits into from
Jun 26, 2023

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Jun 21, 2023 •
edited
Loading

Description

Adds caching ENS lookups to Redis database.

Adds metrics publishing and new Grafana dashboards.

Also adds ability to deploy local changes to dev environment.

Also fixes hashicorp/terraform-provider-aws#28353

Resolves #191
Resolves #107

How Has This Been Tested?

Deployed to dev Terraform environment, made some lookups, checked Grafana charts. Tested against reown-com/appkit#1090

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

chris13524 and others added 15 commits June 19, 2023 22:28
@chris13524 chris13524 self-assigned this Jun 21, 2023
@arein arein added the accepted The issue has been accepted into the project label Jun 21, 2023
@chris13524 chris13524 changed the title feat: identity metrics feat: identity metrics + caching Jun 22, 2023
@chris13524 chris13524 changed the title feat: identity metrics + caching feat: identity caching + metrics Jun 22, 2023
@chris13524 chris13524 marked this pull request as ready for review June 22, 2023 12:15
arein
arein approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only concern is the cardinality of the dimensions

src/handlers/identity.rs Outdated Show resolved Hide resolved
src/handlers/identity.rs Outdated Show resolved Hide resolved
Rakowskiii
Rakowskiii approved these changes Jun 22, 2023
View reviewed changes
src/handlers/identity.rs Outdated Show resolved Hide resolved
src/handlers/identity.rs Show resolved Hide resolved
@chris13524
Copy link
Member Author

chris13524 commented Jun 23, 2023 •
edited
Loading

I still need to do a few tweaks to get this right before merging:

  • Cache 404s (no names for address)
  • Fix latency/availability metrics during 404s
  • Add metric for resolved names (in addition to current resolved avatars)

@chris13524 chris13524 merged commit 0f030f9 into master Jun 26, 2023
@chris13524 chris13524 deleted the chris/identity-metrics branch June 26, 2023 21:27
@chris13524 chris13524 mentioned this pull request Jun 27, 2023
Merged
3 tasks
@chris13524
Copy link
Member Author

Another problem I forgot to fix, but not critical: https://github.com/WalletConnect/rpc-relay/issues/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein approved these changes

@xav xav Awaiting requested review from xav

@Rakowskiii Rakowskiii Awaiting requested review from Rakowskiii

Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENS metrics ENS Caching Notice: S3 - Changes to Defaults (Block Public Access and ACL's)
3 participants
@chris13524 @arein @Rakowskiii