Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicated chains declaration #2999

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Oct 3, 2024

Description

Remove duplicated Solana chains declared on Solana Adapter package.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 81372f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@reown/appkit-adapter-solana Patch
@reown/appkit-solana Patch
@apps/laboratory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 4, 2024 9:59am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 4, 2024 9:59am

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 245.05999999999997% 4262 / 18911
🔵 Statements 245.05999999999997% 4262 / 18911
🔵 Functions 261.23999999999995% 330 / 1004
🔵 Branches 312.40999999999997% 598 / 1275
File CoverageNo changed files found.
Generated in workflow #6585 for commit 81372f2 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Oct 3, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-DubcYgFL.js 1890.677 540.553
assets/index.js 9.63 3.16
assets/index2.js 11.589 3.212
assets/w3m-modal.js 7.452 2.628
assets/noble-curves.js 31.941 12.779
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.524
index.html 0.329 0.236
Total Size 2435.337 705.821

Base Size

Name Size (kb) Gzip (kb)
assets/index-DubcYgFL.js 1890.677 540.553
assets/index.js 9.63 3.16
assets/index2.js 11.589 3.212
assets/w3m-modal.js 7.452 2.628
assets/noble-curves.js 31.941 12.779
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.524
index.html 0.329 0.236
Total Size 2435.337 705.821

@enesozturk enesozturk merged commit 72010c6 into main Oct 4, 2024
17 checks passed
@enesozturk enesozturk deleted the chore/remove-duplicated-solana-chains-declaration branch October 4, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants