Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solana extensions connection #2998

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Oct 3, 2024

Description

This PR is fixing connection with Solana extension wallets due to missing chainId in the rpcUrl. This error was happening because when getting the connection chain, it would use chains from constants instead of the requested chains.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1035
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Oct 3, 2024

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 3, 2024 2:32pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 3, 2024 2:32pm

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: cb52b24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@reown/appkit-adapter-solana Patch
@apps/demo Patch
@apps/gallery Patch
@apps/laboratory Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/next-wagmi-app-router Patch
@examples/next-wagmi-pages-router Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 245.04% 4261 / 18910
🔵 Statements 245.04% 4261 / 18910
🔵 Functions 261.23999999999995% 330 / 1004
🔵 Branches 312.40999999999997% 598 / 1275
File CoverageNo changed files found.
Generated in workflow #6560 for commit cb52b24 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Oct 3, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-Czkt4gCs.js 1890.541 540.504
assets/index.js 9.63 3.16
assets/index2.js 11.589 3.211
assets/w3m-modal.js 7.452 2.627
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.286 25.523
index.html 0.329 0.237
Total Size 2435.201 705.766

Base Size

Name Size (kb) Gzip (kb)
assets/index-Czkt4gCs.js 1890.541 540.504
assets/index.js 9.63 3.16
assets/index2.js 11.589 3.211
assets/w3m-modal.js 7.452 2.627
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.326
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.286 25.523
index.html 0.329 0.237
Total Size 2435.201 705.766

@zoruka zoruka merged commit e1081e9 into main Oct 3, 2024
17 checks passed
@zoruka zoruka deleted the fix/solana-extensions-connection branch October 3, 2024 17:23
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants