refactor: handle viem chains in wagmi adapter constructor #2955
+1,522
−1,163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d73524a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
enesozturk
commented
Oct 4, 2024
enesozturk
commented
Oct 4, 2024
enesozturk
commented
Oct 4, 2024
| @@ -0,0 +1,17 @@ | |||
| import type { CaipNetwork } from '@reown/appkit-common' | |||
enesozturk
commented
Oct 4, 2024
enesozturk
commented
Oct 4, 2024
enesozturk
commented
Oct 4, 2024
enesozturk
commented
Oct 4, 2024
enesozturk
commented
Oct 4, 2024
tomiir
reviewed
Oct 4, 2024
| @@ -99,8 +99,7 @@ export function SolanaTests() { | |||
| <SolanaSignJupiterSwapTest /> | |||
| </Box> | |||
|
|
|||
| {(caipNetwork?.chainId === solanaTestnet.chainId || | |||
| caipNetwork?.chainId === solanaDevnet.chainId) && ( | |||
| {(caipNetwork?.id === solanaTestnet.id || caipNetwork?.id === solanaDevnet.id) && ( | |||
| @@ -0,0 +1,17 @@ | |||
| import type { CaipNetwork } from '@reown/appkit-common' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Wagmi adapter doesn't handle the Viem chains well. Most of the users use
viem's exported chains. The Wagmi adapter should be flexible to use all these chains as well.This PR introduces changes to WagmiAdapter and lab examples to provide proper workaround handling both Viem chains and our exported network objects.
Type of change
Associated Issues
For Linear issues: Closes APKT-1193, APKT-1194, APKT-1195
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist