Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix dockerfile and bring back turbo #2582

Merged
merged 5 commits into from
Jul 22, 2024
Merged

build: fix dockerfile and bring back turbo #2582

merged 5 commits into from
Jul 22, 2024

Conversation

segunadebayo
Copy link
Contributor

@segunadebayo segunadebayo commented Jul 22, 2024

Description

  • Bring back turbo to run tasks
  • Fix Docker Canary
  • Change clean to build:clean

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 22, 2024 5:21pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 22, 2024 5:21pm

@@ -45,7 +44,7 @@
"eslint-plugin-prettier": "5.1.3",
"eslint-plugin-require-extensions": "0.1.3",
"prettier": "3.1.1",
"turbo": "1.11.3",
"turbo": "2.0.6-canary.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only version of turbo that supports PNPM 9

Copy link
Contributor

@enesozturk enesozturk Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow really? Not the 2.0.9 supporting it as I see it's the latest? Is there any ref? @segunadebayo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants