-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enableSwaps option #2573
Merged
enesozturk
merged 5 commits into
main
from
refactor/swaps-feature-flag-and-enable-on-regular-wallets
Jul 22, 2024
Merged
feat: enableSwaps option #2573
enesozturk
merged 5 commits into
main
from
refactor/swaps-feature-flag-and-enable-on-regular-wallets
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
reviewed
Jul 19, 2024
tomiir
approved these changes
Jul 22, 2024
enesozturk
deleted the
refactor/swaps-feature-flag-and-enable-on-regular-wallets
branch
July 22, 2024 16:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces
enableSwaps
flag which allow users to enable/disable swap feature. Also we are adding swap feature to the default account view so even with regular wallets, users will be able to use swaps.By default, swaps are disabled on regular flow, enabled on email flow.
Type of change
Associated Issues
For Linear issues: Closes APKT-752, Closes, APKT-618
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist