Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enableSwaps option #2573

Merged

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jul 19, 2024

Description

Introduces enableSwaps flag which allow users to enable/disable swap feature. Also we are adding swap feature to the default account view so even with regular wallets, users will be able to use swaps.

By default, swaps are disabled on regular flow, enabled on email flow.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-752, Closes, APKT-618
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 22, 2024 3:51pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 22, 2024 3:51pm

Copy link

linear bot commented Jul 19, 2024

@enesozturk enesozturk merged commit 0e1c306 into main Jul 22, 2024
9 checks passed
@enesozturk enesozturk deleted the refactor/swaps-feature-flag-and-enable-on-regular-wallets branch July 22, 2024 16:29
@tomiir tomiir mentioned this pull request Jul 24, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants