Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove 200ms QR delay #2567

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: remove 200ms QR delay #2567

merged 2 commits into from
Jul 19, 2024

Conversation

chris13524
Copy link
Member

Description

Removes excessive delay to display QR codes. Seems like a setTimeout(..., 0) is required for the WalletConnect button case as without it the resizing animation is delayed and there are svg errors for some reason. This issue isn't on the desktop QR.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

@chris13524 chris13524 self-assigned this Jul 18, 2024
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 19, 2024 5:28pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 19, 2024 5:28pm

@chris13524 chris13524 merged commit 527fdce into main Jul 19, 2024
9 checks passed
@chris13524 chris13524 deleted the fix/remove-200ms-qr-delay branch July 19, 2024 18:34
@tomiir tomiir mentioned this pull request Jul 24, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants