Chore/split internal external testing #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
reviewed
Jul 18, 2024
| auth: { | ||
| socials: ['google', 'x', 'discord', 'apple', 'github'] | ||
| }, | ||
| coinbasePreference: 'smartWalletOnly' |
There was a problem hiding this comment.
should we remove this so it defaults to all ?
enesozturk
reviewed
Jul 18, 2024
| termsConditionsUrl: 'https://walletconnect.com/terms', | ||
| privacyPolicyUrl: 'https://walletconnect.com/privacy', | ||
| siweConfig, | ||
| customWallets: ConstantsUtil.CustomWallets |
There was a problem hiding this comment.
Should we add all other possible features?
tokenscustomWalletsallWalletsincludeWalletIdsexcludeWalletIdsfeaturedWalletIdsallowUnsupportedChain
There was a problem hiding this comment.
Not sure if we need to add those, as these are more specific configuration adjustments than actual features. But I agree that we should test these somewhere.
enesozturk
approved these changes
Jul 18, 2024
…lletConnect/web3modal into chore/split-internal-external-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing area is now splitted between
externalandinternal. Internal has all features enabled + custom wallets. External has all features with custom wallets disabled.Type of change
Associated Issues
Closes https://linear.app/walletconnect/issue/APKT-668/put-sample-wallets-in-a-separate-page-of-appkit-lab
Checklist