-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: account with copy click icon #2550
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…tConnect/web3modal into fix/revert-solana-accounts
packages/scaffold-ui/src/partials/w3m-account-default-widget/index.ts
Outdated
Show resolved
Hide resolved
packages/scaffold-ui/src/partials/w3m-account-default-widget/index.ts
Outdated
Show resolved
Hide resolved
packages/scaffold-ui/src/partials/w3m-account-default-widget/index.ts
Outdated
Show resolved
Hide resolved
@@ -1,4 +1,4 @@ | |||
import { createConnector } from '@wagmi/core' | |||
import { createConnector } from 'wagmi' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this as well? (I'm asked the wagmi team about the difference btw, will lyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had some package build issue, but retried now it works
So I'd reverted it
When wagmi team respond - we'll decide
packages/scaffold-ui/src/partials/w3m-account-default-widget/styles.ts
Outdated
Show resolved
Hide resolved
packages/solana/src/client.ts
Outdated
@@ -235,6 +235,8 @@ export class Web3Modal extends Web3ModalScaffold { | |||
) | |||
) | |||
|
|||
OptionsController.state.enableSwaps = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set the flags inside the scaffold/client
along with the others. Please update this line conditionally: https://github.com/WalletConnect/web3modal/blob/main/packages/scaffold/src/client.ts#L355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we only set enableSwaps: false in laboratory ?
Or in scaffold/client I should add workaround if chains are solana-related?
Description
Please include a brief summary of the change.
Type of change
..
Showcase (Optional)