Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account with copy click icon #2550

Merged
merged 45 commits into from
Jul 29, 2024
Merged

fix: account with copy click icon #2550

merged 45 commits into from
Jul 29, 2024

Conversation

phoenixVS
Copy link
Contributor

@phoenixVS phoenixVS commented Jul 17, 2024

Description

Please include a brief summary of the change.

Type of change

  • [* ] Bug fix (non-breaking change which fixes an issue)
  • "Transaction history is coming soon!" paragraph
    ..

Showcase (Optional)

image
image

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 29, 2024 2:11pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 29, 2024 2:11pm

@vercel vercel bot temporarily deployed to Preview – web3modal-laboratory July 19, 2024 12:16 Inactive
apps/laboratory/package.json Show resolved Hide resolved
@@ -1,4 +1,4 @@
import { createConnector } from '@wagmi/core'
import { createConnector } from 'wagmi'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this as well? (I'm asked the wagmi team about the difference btw, will lyk)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had some package build issue, but retried now it works
So I'd reverted it
When wagmi team respond - we'll decide

@@ -235,6 +235,8 @@ export class Web3Modal extends Web3ModalScaffold {
)
)

OptionsController.state.enableSwaps = false
Copy link
Contributor

@enesozturk enesozturk Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set the flags inside the scaffold/client along with the others. Please update this line conditionally: https://github.com/WalletConnect/web3modal/blob/main/packages/scaffold/src/client.ts#L355

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we only set enableSwaps: false in laboratory ?
Or in scaffold/client I should add workaround if chains are solana-related?

packages/solana/src/client.ts Outdated Show resolved Hide resolved
packages/ui/src/utils/ThemeUtil.ts Outdated Show resolved Hide resolved
packages/ui/src/components/wui-text/styles.ts Outdated Show resolved Hide resolved
@enesozturk enesozturk merged commit a6416ab into main Jul 29, 2024
12 checks passed
@enesozturk enesozturk deleted the fix/revert-solana-accounts branch July 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants