fix: not allow multiple account syncs for same caip address #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
approved these changes
Jul 17, 2024
enesozturk
approved these changes
Jul 17, 2024
arein
reviewed
Jul 18, 2024
| if (!isGetCallsStatusSupported()) { | ||
| return ( | ||
| <Text fontSize="md" color="yellow"> | ||
| Wallet does not support wallet_getCallsStatus rpc method |
There was a problem hiding this comment.
Suggested change
| Wallet does not support wallet_getCallsStatus rpc method | |
| Wallet does not support the "wallet_getCallsStatus" RPC method |
| if (!isSendCallsSupported()) { | ||
| return ( | ||
| <Text fontSize="md" color="yellow"> | ||
| Wallet does not support wallet_sendCalls rpc method |
There was a problem hiding this comment.
Suggested change
| Wallet does not support wallet_sendCalls rpc method | |
| Wallet does not support the "wallet_sendCalls" rpc method |
| if (supportedChains.length === 0) { | ||
| return ( | ||
| <Text fontSize="md" color="yellow"> | ||
| Account does not support atomic batch feature |
There was a problem hiding this comment.
Suggested change
| Account does not support atomic batch feature | |
| Account does not support the atomic batch feature |
zoruka
force-pushed
the
fix/multiple-account-syncs-on-wagmi
branch
from
269b960
to
4b182ad
Compare
tomiir
approved these changes
Jul 18, 2024
enesozturk
approved these changes
Jul 18, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is changing the
syncAccountfunction over wagmiWeb3Modalclient to not allow the account data to be fetched twice for the same CAIP. This fixes the issue with account data being fetched multiple times between wagmi'swatchAccountonChange callbacks.Edit: This PR doesn't contain test coverage because the testing setup is a wip being done by @enesozturk.
Type of change
Associated Issues
APKT-684
Showcase (Optional)
The change can be seen on here compared to live, when the account is connected and you refresh the page it updates a single the account info a single time.
Checklist