[TDW] move from npm to pnpm #2545
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Changes look good. |
|
@lukaisailovic I believe this is already covered here |
| "lint": "eslint . --ext .js,.jsx,.ts,.tsx" | ||
| }, | ||
| "dependencies": { | ||
| "@web3modal/common": "5.0.7", | ||
| "@web3modal/ui": "5.0.7", | ||
| "@web3modal/common": "workspace:*", |
There was a problem hiding this comment.
Finally. Love this feature.
| @@ -46,33 +46,33 @@ const chains = [ | |||
| } | |||
| ] | |||
|
|
|||
| const ethersConfig = defaultConfig({ | |||
There was a problem hiding this comment.
Wow really? Surprised how we are missed this in code review, thanks!
| "typecheck": "turbo run typecheck", | ||
| "lint": "turbo run lint", | ||
| "typecheck": "pnpm --if-present -r typecheck", | ||
| "lint": "pnpm -r lint", |
There was a problem hiding this comment.
-r parameter not really clear for me. Do we have to use it? It looks like we need to be careful about, could you explain why we used it?
There was a problem hiding this comment.
--recursive or -r flag is used to run a script in every workspace package.
There was a problem hiding this comment.
Ah yes, the way they described is quite quite different just why:
When used inside a workspace, removes a dependency (or dependencies) from every workspace package.
Description
This PR marks the start of improvements in our overall development experience. This will happen in two steps (and two pull requests):
Migration to PNPM (current): This will reveal hoisted dependencies that weren't installed explicitly and could cause issues on the consumer side. It also helps rely less on turbo since pnpm has a task runner system (and it's fast)
Remove the need to run
watchand read from source directly: This will greatly improve TS performance and the need to "Restart TS Server" when working across packages. Of course, this will come in a different PR.My end goal is to make our lives a bit easier. It's probably not much, but it's worth it.
For this PR, I've done the following:
pnpm-workspace.yaml@web3modal/*package to point toworkspace:*cache: falsein turbo). Happy to bring back turbo once everything works as expected.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist