-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add clientId to BlockchainAPI requests #2521
Conversation
… state variable to blockchain api controller and add handler to scaffold
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -32,6 +32,7 @@ import type { | |||
BlockchainApiRegisterNameParams | |||
} from '../utils/TypeUtil.js' | |||
import { OptionsController } from './OptionsController.js' | |||
import { proxy } from 'valtio' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all core imports should be from valtio/vanilla to avoid react as required dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment 🙌🏽
Description
Adds
clientId
query parameter to blockchain API requests when connecting via the WC relay.Type of change
Associated Issues
Closes APKT-672
Checklist