Fix client.ts: reset EthersStoreUtil's error before new operation #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the EthersStoreUtil's error is not reset before executing a new operation, therefore the value is carried over even for successful operations. With this fix we reset error to undefined before every operation.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dextfprotocol is attempting to deploy a commit to the WalletConnect Team on Vercel. A member of the Team first needs to authorize it. |
svenvoskamp
requested changes
Feb 14, 2024
svenvoskamp
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the EthersStoreUtil's
erroris not reset before executing a new operation, therefore the value is carried over even for successful operations.With this fix we reset
errortoundefinedbefore every operation.Breaking Changes
N/A
Changes
errortoundefinedbefore every operationAssociated Issues
closes #...