feat(replacements): add airbnb-prop-types-to-prop-types-tools #29329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ljharb
changed the title
rarkins
requested changes
May 29, 2024
HonkingGoose
suggested changes
May 29, 2024
rarkins
previously approved these changes
May 29, 2024
6 tasks
auto-merge was automatically disabled
May 29, 2024 19:28
Head branch was pushed to by a user without write access
ljharb
force-pushed
the
patch-1
branch
2 times, most recently
from
e13e95d
to
84935d1
Compare
|
oops, sorry, i forgot that you don't want me to force push :-/ i do it everywhere else on github so it's a habit. |
HonkingGoose
reviewed
Jun 7, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
reviewed
Jun 7, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
reviewed
Jun 7, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
previously approved these changes
Jun 7, 2024
|
now prettier complains😂 |
|
This is getting too much like Whack-A-Mole:
Silly idea incoming: maybe we need a Prettier ignore for the ESLint ignore... 🙃 |
rarkins
approved these changes
Jun 10, 2024
|
🎉 This PR is included in version 37.400.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@ljharb congratulations on getting your first PR merged. 🥳 Thank you for sticking with us during the review process! ❤️ I'm happy we finally managed to get our linter ducks in a row. 🦆 🦆 🦆 |
|
Thanks :-p |
kosmoz
pushed a commit
to kosmoz/renovate
that referenced
this pull request
Jun 12, 2024
…tebot#29329) Co-authored-by: Rhys Arkins <rhys@arkins.net> Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace
airbnb-prop-typeswith its new name,prop-types-toolsContext
Airbnb gave me the repo, but made me rename the npm package to not have "airbnb" in it.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: