fix: prPriority based sorting of prs (#29306)

renovatebot · May 29, 2024 · 9e2ca6b · 9e2ca6b
1 parent 6dd189e
commit 9e2ca6b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/workers/repository/process/sort.spec.ts b/lib/workers/repository/process/sort.spec.ts
@@ -58,11 +58,16 @@ describe('workers/repository/process/sort', () => {
           prTitle: 'a minor update',
           prPriority: -1,
         },
+        {
+          updateType: 'patch' as UpdateType,
+          prTitle: 'a patch update',
+        },
       ];
       sortBranches(branches);
       expect(branches).toEqual([
         { prPriority: 1, prTitle: 'some major update', updateType: 'major' },
         { prPriority: 0, prTitle: 'some other pin', updateType: 'pin' },
+        { prTitle: 'a patch update', updateType: 'patch' },
         { prPriority: -1, prTitle: 'some pin', updateType: 'pin' },
         { prPriority: -1, prTitle: 'a minor update', updateType: 'minor' },
       ]);

diff --git a/lib/workers/repository/process/sort.ts b/lib/workers/repository/process/sort.ts
@@ -21,8 +21,9 @@ export function sortBranches(branches: Partial<BranchConfig>[]): void {
     }
 
     // TODO #22198
-    if (a.prPriority !== b.prPriority) {
-      return b.prPriority! - a.prPriority!;
+    const prPriorityDiff = getPrPriority(b) - getPrPriority(a);
+    if (prPriorityDiff !== 0) {
+      return prPriorityDiff;
     }
     // TODO #22198
     const sortDiff =
@@ -35,3 +36,7 @@ export function sortBranches(branches: Partial<BranchConfig>[]): void {
     return a.prTitle! < b.prTitle! ? -1 : 1;
   });
 }
+
+function getPrPriority(branch: Partial<BranchConfig>): number {
+  return branch.prPriority ?? 0;
+}