Support for project scoped package feeds. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Artifacts now supports both organization and project scoped package feeds. The fully qualified name for the package feeds is {ProjectName}/{PackageFeed} (project scoped) or {PackageFeed} (organization scoped).
Updated the powershell script to extract out the projectId if the package feed was project scoped. Either the project feed remains an empty string or the projectId is populated and the feedName is shortened using the String.Split() function.
|
One thing to note, this does not resolve the issue around the Release views dropdown properly populating because the "tfs:feed" url is not the correct url for project scoped feeds. |
Won't this still prevent it from working in the Classic editor and in Release pipelines? |
|
When will this pull request be completed? We are waiting for this fix so we can use this task again. thanks |
|
I will merge this. Can you send me your Azure DevOps organizations, so I can share the extension with you privately and you can test it as well? Thanks! |
|
Hello Rene,
Thanks for the reply.
Our organization is PA-GGDC (https://dev.azure.com/PA-GGDC/).
I very much appreciate this extension and look forward to testing it.
Thanks again!
J. Mike Zserai, BSCS, ITIL® v3 | Senior Applications Developer
PA Office of Administration | General Government Delivery Center
Forum Place 7th Floor | 555 Walnut Street | Hbg, PA 17101
Phone: 717.836.3504
www.oa.pa.gov<http://www.oa.pa.gov/>
From: Rene van Osnabrugge <notifications@github.com>
Sent: Wednesday, January 15, 2020 11:41 AM
To: renevanosnabrugge/vsts-promotepackage-task <vsts-promotepackage-task@noreply.github.com>
Cc: Zserai, J <jzserai@pa.gov>; Manual <manual@noreply.github.com>
Subject: [External] Re: [renevanosnabrugge/vsts-promotepackage-task] Support for project scoped package feeds. (#42)
ATTENTION: This email message is from an external sender. Do not open links or attachments from unknown sources. To report suspicious email, forward the message as an attachment to CWOPA_SPAM@pa.gov.
I will merge this. Can you send me your Azure DevOps organizations, so I can share the extension with you privately and you can test it as well? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fpull%2F42%3Femail_source%3Dnotifications%26email_token%3DABJALPXFUEUE5AUPY3HB7QDQ544DFA5CNFSM4KCZUEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJA63LI%23issuecomment-574746029&data=02%7C01%7Cjzserai%40pa.gov%7C0099110d492a4c075faa08d799d9c1aa%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637147033299856820&sdata=BcEzW98Bg6Z9PnXM8QRmfOIdXhc1UowY3G8DYaqZ3ZI%3D&reserved=0>, or unsubscribe<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABJALPX7FW7LRRPIFZKPE4DQ544DFANCNFSM4KCZUEMA&data=02%7C01%7Cjzserai%40pa.gov%7C0099110d492a4c075faa08d799d9c1aa%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637147033299856820&sdata=1Z0WQJqYOp%2B1Jye5YOHtebqnukRCBRvxIgHZ7a0Cfbc%3D&reserved=0>.
|
|
Hi Rene,
Our organization is https://dev.azure.com/MontaDevelopment
Thank,
Juri
Op wo 15 jan. 2020 om 17:41 schreef Rene van Osnabrugge <
notifications@github.com>:
… I will merge this. Can you send me your Azure DevOps organizations, so I
can share the extension with you privately and you can test it as well?
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=AODTSXNF6EIB42VUMB2264TQ544DFA5CNFSM4KCZUEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJA63LI#issuecomment-574746029>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AODTSXOG3TPH4TZ6D5IXDNLQ544DFANCNFSM4KCZUEMA>
.
--
Juri van Tuijl
-----------------------------
E: jurivt@gmail.com
T: 06 46 28 85 14
|
|
pushed a new version to your accounts |
|
Hello Rene,
Thanks for the quick turn-around on this. It’s appreciated very much.
I tested it on both a project-scoped feed and our organization feed and it promotes the packages correctly in both.
Because the release View drop-down doesn’t populate for project feeds, I simply used variables and typed it in:
* $(PrereleaseView) = Prerelease, $(ReleaseView) = Release (viewId does not work here)
* To use a project feed variable in the ‘Use packages from this VSTS feed’ drop-down, it has to be fully-qualified;
* $(System.TeamProject)/$(ProjectFeedName) e.g. ‘GGDC/GG_Lib’
* feedId does not work here, even though sometimes it is populated with the feed Id after saving and refreshing
You may want to add a ToolTip to the release view drop-down to let users know how to populate it themselves when using project feeds.
All in all, it’s a stellar extension.
Thanks again Rene
J. Mike Zserai, BSCS, ITIL® v3 | Senior Applications Developer
PA Office of Administration | General Government Delivery Center
Forum Place 7th Floor | 555 Walnut Street | Hbg, PA 17101
Phone: 717.836.3504
www.oa.pa.gov<http://www.oa.pa.gov/>
From: Rene van Osnabrugge <notifications@github.com>
Sent: Thursday, January 16, 2020 4:55 AM
To: renevanosnabrugge/vsts-promotepackage-task <vsts-promotepackage-task@noreply.github.com>
Cc: Zserai, J <jzserai@pa.gov>; Manual <manual@noreply.github.com>
Subject: [External] Re: [renevanosnabrugge/vsts-promotepackage-task] Support for project scoped package feeds. (#42)
ATTENTION: This email message is from an external sender. Do not open links or attachments from unknown sources. To report suspicious email, forward the message as an attachment to CWOPA_SPAM@pa.gov.
pushed a new version to your accounts
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fpull%2F42%3Femail_source%3Dnotifications%26email_token%3DABJALPQWOYYLBQ5J64P2VB3Q6AVHPA5CNFSM4KCZUEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJDOZHA%23issuecomment-575073436&data=02%7C01%7Cjzserai%40pa.gov%7Cced67673815146119eae08d79a6a2964%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637147653522849289&sdata=OVWWMt3lD5DQwLKDTKlMsEmciSqJ2WKN%2BOogOIskPi4%3D&reserved=0>, or unsubscribe<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABJALPQJSCBJOT3UBAXTC63Q6AVHPANCNFSM4KCZUEMA&data=02%7C01%7Cjzserai%40pa.gov%7Cced67673815146119eae08d79a6a2964%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637147653522849289&sdata=jOFBx12vyORqlIebwrtSar0qf324maGOFbg%2BQyPN3jE%3D&reserved=0>.
|
|
Hi Rene,
We have now have version 3.0.1. and we also tried it, but we keep some
errors (with local and remote agents). See the error messagese below.
Any idea what we are doing wrong?
Thanks,
Juri
*Error message Azure Pipelines:*
Unhandled exception while reading feed 4377f9b6-1f9e-4592-b2bc-2eca970e23db
System.Net.WebException: The remote server returned an error: (404) Not
Found.
at
Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest
request)
at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()at
Get-FeedId,
D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.1\vsts-promotepackage-task.ps1:
line 48
at Set-PackageQuality,
D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.1\vsts-promotepackage-task.ps1:
line 137
at Run,
D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.1\vsts-promotepackage-task.ps1:
line 283
at <ScriptBlock>,
D:\a\_tasks\rvo-vsts-promotepackage-task_7ca5869f-a901-4012-a50d-d0f9d436ffec\3.0.1\vsts-promotepackage-task.ps1:
line 289
at <ScriptBlock>, <No file>: line 1
at <ScriptBlock>, <No file>: line 22
at <ScriptBlock>, <No file>: line 18
at <ScriptBlock>, <No file>: line 1
*Error message Local Agent: *2020-01-17T06:41:57.2124192Z Matching paths
found:
2020-01-17T06:41:57.2126161Z
E:\_work\agent2\r6\a\_MontaTestRepo\NuGetFiles\MontaTest.0.11.0.nupkg
2020-01-17T06:41:57.4003355Z ##[error]Cannot bind argument to parameter
'Path' because it is null.
*Agent Job Yaml*
variables:
ReleaseView: 'Release'
steps:
- task:
rvo.vsts-promotepackage-task.vsts-promotepackage-task.rvo-vsts-promotepackage-task@3
displayName: 'Promote package to Release View'
inputs:
feed: '4377f9b6-1f9e-4592-b2bc-2eca970e23db'
inputType: packageFiles
releaseView: '$(ReleaseView)'
Op do 16 jan. 2020 om 18:01 schreef jzserai <notifications@github.com>:
… Hello Rene,
Thanks for the quick turn-around on this. It’s appreciated very much.
I tested it on both a project-scoped feed and our organization feed and it
promotes the packages correctly in both.
Because the release View drop-down doesn’t populate for project feeds, I
simply used variables and typed it in:
* $(PrereleaseView) = Prerelease, $(ReleaseView) = Release (viewId does
not work here)
* To use a project feed variable in the ‘Use packages from this VSTS feed’
drop-down, it has to be fully-qualified;
* $(System.TeamProject)/$(ProjectFeedName) e.g. ‘GGDC/GG_Lib’
* feedId does not work here, even though sometimes it is populated with
the feed Id after saving and refreshing
You may want to add a ToolTip to the release view drop-down to let users
know how to populate it themselves when using project feeds.
All in all, it’s a stellar extension.
Thanks again Rene
J. Mike Zserai, BSCS, ITIL® v3 | Senior Applications Developer
PA Office of Administration | General Government Delivery Center
Forum Place 7th Floor | 555 Walnut Street | Hbg, PA 17101
Phone: 717.836.3504
www.oa.pa.gov<http://www.oa.pa.gov/>
From: Rene van Osnabrugge ***@***.***>
Sent: Thursday, January 16, 2020 4:55 AM
To: renevanosnabrugge/vsts-promotepackage-task <
***@***.***>
Cc: Zserai, J ***@***.***>; Manual ***@***.***>
Subject: [External] Re: [renevanosnabrugge/vsts-promotepackage-task]
Support for project scoped package feeds. (#42)
ATTENTION: This email message is from an external sender. Do not open
links or attachments from unknown sources. To report suspicious email,
forward the message as an attachment to ***@***.***
pushed a new version to your accounts
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<
https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fpull%2F42%3Femail_source%3Dnotifications%26email_token%3DABJALPQWOYYLBQ5J64P2VB3Q6AVHPA5CNFSM4KCZUEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJDOZHA%23issuecomment-575073436&data=02%7C01%7Cjzserai%40pa.gov%7Cced67673815146119eae08d79a6a2964%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637147653522849289&sdata=OVWWMt3lD5DQwLKDTKlMsEmciSqJ2WKN%2BOogOIskPi4%3D&reserved=0>,
or unsubscribe<
https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABJALPQJSCBJOT3UBAXTC63Q6AVHPANCNFSM4KCZUEMA&data=02%7C01%7Cjzserai%40pa.gov%7Cced67673815146119eae08d79a6a2964%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637147653522849289&sdata=jOFBx12vyORqlIebwrtSar0qf324maGOFbg%2BQyPN3jE%3D&reserved=0>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=AODTSXJMIPLVH2R752RFAXLQ6CHHXA5CNFSM4KCZUEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEZLXI#issuecomment-575247837>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AODTSXNB3AIF2I2ESPWIVIDQ6CHHXANCNFSM4KCZUEMA>
.
--
Juri van Tuijl
-----------------------------
E: jurivt@gmail.com
T: 06 46 28 85 14
|
|
Hi. The extension I shared with you is a private extension with version 1.5.2 .You can unfortunately not run side by side. So uninstall the extension (or use another account) and reinstall the private extension from the extension page.. |
|
Thanks Rene, it is working now! |
|
although using a agent from our local pool we still get the error: "##[error]Cannot bind argument to parameter 'Path' because it is null." With the default azure pipelines agens it's working fine. |
|
Is the extension supposed to work on a local agent? I tested it with a Hosted agent.
J. Mike Zserai, BSCS, ITIL® v3 | Senior Applications Developer
PA Office of Administration | General Government Delivery Center
Forum Place 7th Floor | 555 Walnut Street | Hbg, PA 17101
Phone: 717.836.3504
www.oa.pa.gov<http://www.oa.pa.gov/>
From: juritdev <notifications@github.com>
Sent: Friday, January 17, 2020 2:43 AM
To: renevanosnabrugge/vsts-promotepackage-task <vsts-promotepackage-task@noreply.github.com>
Cc: Zserai, J <jzserai@pa.gov>; Manual <manual@noreply.github.com>
Subject: [External] Re: [renevanosnabrugge/vsts-promotepackage-task] Support for project scoped package feeds. (#42)
ATTENTION: This email message is from an external sender. Do not open links or attachments from unknown sources. To report suspicious email, forward the message as an attachment to CWOPA_SPAM@pa.gov.
although using a agent from our local pool we still get the error: "##[error]Cannot bind argument to parameter 'Path' because it is null."
With the default azure pipelines agens it's working fine.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frenevanosnabrugge%2Fvsts-promotepackage-task%2Fpull%2F42%3Femail_source%3Dnotifications%26email_token%3DABJALPSYVHI3AG7DWWVIFTLQ6FOR5A5CNFSM4KCZUEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJG2IRQ%23issuecomment-575513670&data=02%7C01%7Cjzserai%40pa.gov%7C667a22d37d7642e4ba6808d79b20f107%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637148438525963830&sdata=AbRD5VNtecMvR7Hpuejj2irN3TGgct2oSLNBsz3IgMI%3D&reserved=0>, or unsubscribe<https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABJALPWKNTDCYB52IJTGKLDQ6FOR5ANCNFSM4KCZUEMA&data=02%7C01%7Cjzserai%40pa.gov%7C667a22d37d7642e4ba6808d79b20f107%7C418e284101284dd59b6c47fc5a9a1bde%7C0%7C0%7C637148438525963830&sdata=N7spNrzMKhLAbjLZkzYLpZfkWoOk%2FxQBONZ8IIHN6to%3D&reserved=0>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there was no contribution.md file, I wasn't sure if our contributions should include updating the version numbers for the task/extension.
Also, I had the task extract the name portion of the package instead of the guid for readability in YAML pipeline files. The classic build/release editors are not affected. Feel free to alter this if necessary.
Finally, I added a schema mark for the task.json file. I could get the local tests to run properly because my work machine has group policies around powershell scripts and our security team blocks certain network traffic. But I did verify this works by creating a private package and using that in our pipeline.