Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on rollup-plugin-node-polyfills #36

Closed
wants to merge 1 commit into from

Conversation

Regaddi
Copy link

@Regaddi Regaddi commented Mar 24, 2023

The rollup-plugin-node-polyfills repository hasn't been maintained in 4 years. The EventEmitter spec has grown since then, e.g. the .off method has been added and using libraries based on EventEmitter can break builds.

This PR updates the dependency to use the currently maintained fork at https://github.com/FredKSchott/rollup-plugin-polyfill-node, with the latest updates.

The [rollup-plugin-node-polyfills repository](https://github.com/ionic-team/rollup-plugin-node-polyfills) hasn't been maintained in 4 years.
The EventEmitter spec has grown since then, e.g. the `.off` method has been added and using libraries based on `EventEmitter` can break builds.

This PR updates the dependency to use the currently maintained fork at https://github.com/FredKSchott/rollup-plugin-polyfill-node, with the latest updates.
@Regaddi
Copy link
Author

Regaddi commented Mar 27, 2023

Just noticed this is probably some kind of duplicate to #32 and #29.
Closing.

@Regaddi Regaddi closed this Mar 27, 2023
@Regaddi Regaddi deleted the patch-1 branch March 27, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant