Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1-route-convention): allow sibling pathless layout routes #20

Merged
merged 3 commits into from
May 24, 2023

Conversation

brophdawg11
Copy link
Contributor

Same change added in remix-run/remix#4421

@MichaelDeBoey MichaelDeBoey changed the title Allow sibling pathless layout routes fix(v1-route-convention): allow sibling pathless layout routes May 16, 2023
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add tests for this? 🤔

@brophdawg11
Copy link
Contributor Author

ooh, yeah, I didn't actually realize this repo had tests. I'll copy some over from the Remix PR.

@brophdawg11 brophdawg11 merged commit a2653d0 into main May 24, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/sibling-pathless-routes branch May 24, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants