Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ?inline and ?raw from critical styles in dev #9910

Conversation

dj-rabel
Copy link
Contributor

  • css files with query ?url, ?inline or ?raw shouldn't be injected on SSR bei vite spec
  • a combination of these query-params is possible. This is checked as well

Closes: #9844

  • Docs (not needed?)
  • Tests

Testing Strategy:

…y from being injected falsely

- css files with query ?url, ?inline or ?raw shouldn't be injected on SSR bei vite spec
- a combination of these query-params is possible. This is checked as well

closes 9844
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 23, 2024

Hi @dj-rabel,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 7e7c153

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 23, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@markdalgleish markdalgleish changed the title fix(#9844): Adds check to prevent some css imports with query from being injected falsely Exclude ?inline and ?raw from critical styles in dev Sep 16, 2024
@markdalgleish
Copy link
Member

Thanks for the PR! This is a really great catch.

I've pushed some refactors to make the code a little easier to follow by avoiding a regular expression, and expanded the tests a bit.

@markdalgleish markdalgleish merged commit 6eedd68 into remix-run:dev Sep 16, 2024
9 checks passed
Copy link
Contributor

🤖 Hello there,

We just published version 2.12.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.12.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants