Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vite critical CSS resolution when cwd differs from project root #8752

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

frandiox
Copy link
Contributor

Hi 👋

While integrating Remix<>Hydrogen in workerd, I found a weird issue with path resolution when applying critical CSS. Turns out it was resolving app/entry.client.tsx using process.cwd() (by omission) instead of rootDirectory, which can be different in some situations.

Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: d316123

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@markdalgleish markdalgleish changed the title Fix resolving filepath from root Fix Vite critical CSS resolution when cwd differs from project root Feb 15, 2024
@markdalgleish markdalgleish merged commit 291e729 into remix-run:dev Feb 15, 2024
9 checks passed
Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants