Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): avoid Cloudflare manifest import warning #7199

Closed

Conversation

markdalgleish
Copy link
Member

Consumers can avoid bundling Cloudflare's built-in __STATIC_CONTENT_MANIFEST module with the following Remix config which is part of the Cloudflare Workers template:

  serverDependenciesToBundle: [
    /^(?!.*\b__STATIC_CONTENT_MANIFEST\b).*$/,
  ],

However, they still receive a warning in the terminal telling them that they didn't install it because require.resolve can't find it. In the same way that we ignore Node built-in modules, this PR extends our logic to ignore this Cloudflare built-in module.

@markdalgleish markdalgleish added package:dev v2 Issues related to v2 apis labels Aug 21, 2023
@markdalgleish markdalgleish self-assigned this Aug 21, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

🦋 Changeset detected

Latest commit: e4950f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish
Copy link
Member Author

Closing in favour of skipping this check entirely: #7214

@markdalgleish markdalgleish deleted the markdalgleish/silence-cloudflare-manifest-warnings branch August 21, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed package:dev v2 Issues related to v2 apis
Projects
No open projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

1 participant