Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-remix): fix git repo path collisions #7194

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

brophdawg11
Copy link
Contributor

npx create-remix@nightly --template https://github.com/remix-run/remix/tree/dev/templates/remix

this was inadvertently extracting stuff from templates/remix-javascript into a -javascript/ folder due to the startsWith check passing

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

⚠️ No Changeset found

Latest commit: b67656a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 merged commit 0e1e2c3 into dev Aug 21, 2023
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/create-remix-path-collision-bug branch August 21, 2023 13:54
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 21, 2023
@MichaelDeBoey MichaelDeBoey changed the title Fix bug in create-remix git repo path collisions fix(create-remix): fix git repo path collisions Aug 21, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-bd289fa-20230822 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:create-remix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants