Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remix-dev): stop ignoring missing react-dom/client for React 17 #7179

Merged

Conversation

MichaelDeBoey
Copy link
Member

This basically reverts @pcattori's #6725 now that we only support React 18

Should have been part of #7121

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

⚠️ No Changeset found

Latest commit: 150e5f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey merged commit a692805 into remix-run:dev Aug 16, 2023
9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the stop-ignoring-for-react-17 branch August 16, 2023 01:19
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-96b05af-20230816 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed package:dev v2 Issues related to v2 apis
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants