Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use TS where possible #7001

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

MichaelDeBoey
Copy link
Member

This keeps things consistent in docs + in tests

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

⚠️ No Changeset found

Latest commit: c4adc3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

I'd prefer to wait to merge anything of this scale until v2 is released. That way if we do end up needing to do more 1.19.x releases we don't find ourselves with large merge conflicts from main -> dev.

@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Aug 1, 2023

@brophdawg11 Although this is a docs/test change, I created this against dev for the exact reason of possible merge conflicts

@brophdawg11
Copy link
Contributor

Yeah, the concern is just any new integration tests that come along with 1.19.x changes - but since we're basically done with code removals and just going to be bug squashing the next week or two I guess we probably won't end up with too much more in 1.19.x. So yeah ... let's go ahead and get this merged 👍

@brophdawg11 brophdawg11 merged commit a7fd80c into remix-run:dev Aug 3, 2023
9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the use-TS-where-possible branch August 3, 2023 14:59
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-cc9f65c-20230804 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🤖 Hello there,

We just published version 1.19.2-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-6e250f7-20230805 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants