Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): cache CSS side-effects transform for HMR #6622

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

markdalgleish
Copy link
Member

This addSuffixToCssSideEffectImports function used internally within cssSideEffectImportsPlugin had its own cache, but this caching mechanism didn't factor in the newly added HMR work.

This PR replaces the custom caching mechanism with our new fileWatchCache, allowing us to more easily capture all plugin logic (including the HMR transform) in the cache.

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

🦋 Changeset detected

Latest commit: 6447f90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish marked this pull request as draft June 16, 2023 05:28
@markdalgleish markdalgleish marked this pull request as ready for review June 19, 2023 00:40
@pcattori pcattori merged commit aa896a4 into dev Jun 19, 2023
9 checks passed
@pcattori pcattori deleted the markdalgleish/cache-css-side-effects-hmr branch June 19, 2023 06:17
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jun 19, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-aa896a4-20230619 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants