Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): skip Vanilla Extract plugin if not installed #6345

Merged
merged 1 commit into from
May 8, 2023

Conversation

markdalgleish
Copy link
Member

Closes: #6314

This ensures that, in the rare case that someone is using a .css.js/ts file extension when not using Vanilla Extract in their app, we don't inadvertently try to process it with the Vanilla Extract plugin.

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

🦋 Changeset detected

Latest commit: a7422b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish changed the title fix(dev): disable Vanilla Extract if not installed fix(dev): skip Vanilla Extract plugin if not installed May 8, 2023
@MichaelDeBoey MichaelDeBoey linked an issue May 8, 2023 that may be closed by this pull request
1 task
@markdalgleish markdalgleish merged commit c7ad951 into dev May 8, 2023
@markdalgleish markdalgleish deleted the markdalgleish/detect-vanilla-extract branch May 8, 2023 00:48
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-c7ad951-20230508 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Side-Effect Imports not working anymore with Cloudscape
2 participants