Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): dev server listens for updated build hash before writing server files #6294

Merged
merged 1 commit into from
May 3, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented May 3, 2023

previously there was a race where the app server could respond with the updated manifest version (aka build hash) before the dev server was listening for that version.

Closes: #

  • Docs
  • Tests

Testing Strategy:

…rver files

previously there was a race where the app server could respond with the
updated manifest version (aka build hash) _before_ the dev server was
listening for that version.
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

🦋 Changeset detected

Latest commit: 895b403

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit 362eec7 into dev May 3, 2023
@pcattori pcattori deleted the pedro/fix-manifest-race branch May 3, 2023 18:01
@brandonpittman
Copy link

@pcattori Is this in 1.16.0?

@pcattori
Copy link
Contributor Author

@pcattori Is this in 1.16.0?

@brandonpittman , no this is not in 1.16. will be in next release.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants