Add support for mjs and cjs extensions with CSS imports #5564
Conversation
Co-authored-by: Logan McAnsh <logan@mcan.sh>
🦋 Changeset detectedLatest commit: ad1fede The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @devongovett, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Thanks for the PR! 🙏 |
|
🤖 Hello there, We just published version Thanks! |
…emix-run#5564) Co-authored-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Mark Dalgleish <mark.john.dalgleish@gmail.com>
Closes: #5562
In the latest release of React Spectrum we added support for Node ESM, and now distribute a
.mjsbuild. This appears to have broken the CSS loader with Remix: adobe/react-spectrum#4118. Looks like the.mjsand.cjsextensions were missing in the esbuild plugin filter, so I've gone ahead and added them here.Testing Strategy: Updated integration tests, and tested by patching an example app with React Spectrum.