-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-server-runtime): make serializeError
a synchronous function
#5547
Conversation
🦋 Changeset detectedLatest commit: bb72154 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @xuchaobei, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
serializeError
to sync functionserializeError
a synchronous function
Hi @xuchaobei! Are you still interested in getting this one merged? If so, please rebase onto latest |
Looks like |
Error occurred in streaming SSR cannot be serialized correctly, since
serializeError
return a Promise. I supposeserializeError
can just be a sync function.https://github.com/remix-run/remix/blob/main/packages/remix-server-runtime/responses.ts#L209
Closes: #
Testing Strategy:
I opened up my mac machine and ran this script: