Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-server-runtime): make serializeError a synchronous function #5547

Closed
wants to merge 2 commits into from

Conversation

xuchaobei
Copy link

Error occurred in streaming SSR cannot be serialized correctly, since serializeError return a Promise. I suppose serializeError can just be a sync function.

image

https://github.com/remix-run/remix/blob/main/packages/remix-server-runtime/responses.ts#L209

Closes: #

  • Docs
  • Tests

Testing Strategy:

I opened up my mac machine and ran this script:

 npx create-remix@0.0.0-experimental-7e420ee3 --template remix my-test
 cd my-test
 npm run dev

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

🦋 Changeset detected

Latest commit: bb72154

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/testing Patch
@remix-run/vercel Patch
@remix-run/serve Patch
remix Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 23, 2023

Hi @xuchaobei,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 23, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 24, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@machour machour removed the needs-response We need a response from the original author about this issue/PR label Apr 30, 2023
@MichaelDeBoey MichaelDeBoey changed the title fix: change serializeError to sync function fix(remix-server-runtime): make serializeError a synchronous function May 2, 2023
@MichaelDeBoey
Copy link
Member

Hi @xuchaobei!

Are you still interested in getting this one merged?

If so, please rebase onto latest dev & resolve conflicts

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 2, 2023
@brophdawg11
Copy link
Contributor

Looks like async was removed in #5541 so we can close this out.

@brophdawg11 brophdawg11 closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed needs-response We need a response from the original author about this issue/PR package:server-runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants