Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(templates): remove entry.{client,server} as they're now optional #5455

Merged
merged 1 commit into from
Mar 6, 2023
Merged

chore(templates): remove entry.{client,server} as they're now optional #5455

merged 1 commit into from
Mar 6, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Feb 14, 2023 •
edited
Loading

note: leaving this as a draft until this is released (1.14.0)
note: we're keeping these files in the stacks

Closes #5474

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d304c31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh changed the title chore(templates): remove entry.client and entry.server as they're now optional chore(templates): remove entry.{client,server} as they're now optional Feb 14, 2023
@mcansh mcansh force-pushed the logan/remove-entries-from-templates branch from 11a3ad3 to be64352 Compare February 14, 2023 20:54
@mcansh mcansh marked this pull request as ready for review February 15, 2023 20:27
@mcansh mcansh linked an issue Feb 15, 2023 that may be closed by this pull request
remove entry.{client,server} from templates #5474
Closed
This was referenced Feb 15, 2023
Closed
Merged
@mcansh mcansh marked this pull request as draft February 15, 2023 21:39
@mcansh mcansh marked this pull request as ready for review March 6, 2023 16:33
@mcansh mcansh closed this Mar 6, 2023
@mcansh mcansh reopened this Mar 6, 2023
@mcansh mcansh force-pushed the logan/remove-entries-from-templates branch from be64352 to d304c31 Compare March 6, 2023 16:35
@mcansh
Copy link
Collaborator Author

mcansh commented Mar 6, 2023

1.14.0 was released https://github.com/remix-run/remix/releases/tag/remix%401.14.0

@mcansh mcansh merged commit 4988875 into main Mar 6, 2023
@mcansh mcansh deleted the logan/remove-entries-from-templates branch March 6, 2023 16:56
This was referenced Mar 9, 2023
Closed
Closed
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request Mar 15, 2023
Closed
mcansh added a commit that referenced this pull request Mar 24, 2023
@mcansh
Revert "chore(templates): remove entry.{client,server} as they're n…
eae81cc 
…ow optional (#5455)"

This reverts commit 4988875.
@mcansh mcansh mentioned this pull request Mar 24, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed template:architect template:cloudflare-pages template:cloudflare-workers template:deno template:express template:fly template:netlify template:remix template:vercel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove entry.{client,server} from templates
2 participants
@mcansh @MichaelDeBoey