Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: log errors during initial build in development #5441

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix: log errors during initial build in development #5441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b0f95e
Log errors in dev initial build
frandiox Feb 13, 2023
0b0bfa5
Pass onCompileFailure in another call
frandiox Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-doors-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Log errors thrown during initial build in development.
4 changes: 2 additions & 2 deletions packages/remix-dev/compiler/watch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export async function watch(
let compiler = createRemixCompiler(config, options);

// initial build
await compile(compiler);
await compile(compiler, { onCompileFailure });
onInitialBuild?.(Date.now() - start);

let restart = debounce(async () => {
Expand All @@ -77,7 +77,7 @@ export async function watch(
}

compiler = createRemixCompiler(config, options);
let assetsManifest = await compile(compiler);
let assetsManifest = await compile(compiler, { onCompileFailure });
onRebuildFinish?.(Date.now() - start, assetsManifest);
}, 500);

Expand Down