Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/styling): fix Tailwind CSS installation instructions #5252

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

adamwathan
Copy link
Contributor

Doing this from my phone while getting my kid ready for school forgive me for not being able to fill in the template 😅

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

⚠️ No Changeset found

Latest commit: 98fbf72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 25, 2023

Hi @adamwathan,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@MichaelDeBoey MichaelDeBoey changed the title Fix Tailwind CSS installation instructions docs(guides/styling): fix Tailwind CSS installation instructions Jan 25, 2023
@MichaelDeBoey
Copy link
Member

@adamwathan We can only merge this PR if you sign the CLA.

Since you're at you're phone, I'm happy to add your name to the contributors.yml file if you want.

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adamwathan 🙏🏼

@machour
Copy link
Collaborator

machour commented Jan 25, 2023

oh, we just need you to sign the CLA by adding your username to contributors.md, and target the main branch instead of dev

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 25, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@adamwathan adamwathan changed the base branch from dev to main January 25, 2023 14:07
@adamwathan adamwathan changed the base branch from main to dev January 25, 2023 14:08
@adamwathan
Copy link
Contributor Author

oh, we just need you to sign the CLA by adding your username to contributors.md, and target the main branch instead of dev

Hey! The main branch doesn't have the mistake, it's only present in the dev branch and was just introduced in this PR:

#5229

@MichaelDeBoey MichaelDeBoey merged commit d0b1c74 into remix-run:dev Jan 25, 2023
@markdalgleish
Copy link
Member

Thanks @adamwathan! Sorry for the slip-up 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants