Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Add support for remix config feature flags #4566

Merged
merged 10 commits into from
Nov 14, 2022

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Nov 10, 2022

Adds preliminary tests for feature flags in remix.config.

While this technically adds compiler support for the v2_meta feature flag, the actual implementation for that feature will come in a follow-up PR. I wanted this PR to include a feature to show how we plan to enable opt-in features.

  • Docs
  • Tests

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

🦋 Changeset detected

Latest commit: 832e852

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue with unbundled server-side usage - but working well otherwise 👍

packages/remix-dev/index.ts Show resolved Hide resolved
packages/remix-dev/compiler/compilerServer.ts Outdated Show resolved Hide resolved
@ryanflorence ryanflorence mentioned this pull request Nov 14, 2022
2 tasks
@chaance chaance merged commit 95b7fd1 into dev Nov 14, 2022
@chaance chaance deleted the chance/config-features branch November 14, 2022 19:33
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 14, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-95b7fd1-20221115 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
* add support for remix config future flags
* put `future` on entry context for runtime access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants