feat(remix-server-runtime): MetaFunction type infers data and parentsData types from loaders
#4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 591895a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
commented
Aug 19, 2022
Comment on lines
+137
to
+142
| data: Loader extends LoaderFunction ? SerializeFrom<Loader> : AppData; | ||
| parentsData: { | ||
| [k in keyof ParentsLoaders]: SerializeFrom<ParentsLoaders[k]>; | ||
| } & RouteData; |
There was a problem hiding this comment.
AppData and RouteData included for backwards compatibility. In v2, we should change AppData to unknown and remove the need for AppData and RouteData here:
// In Remix v2:
export interface MetaFunction<
Loader extends LoaderFunction,
ParentsLoaders extends Record<string, LoaderFunction> = {}
> {
(args: {
data: SerializeFrom<Loader>;
parentsData: {
[k in keyof ParentsLoaders]: SerializeFrom<ParentsLoaders[k]>;
};
...
pcattori
changed the title
data and parentsData types …data and parentsData types from loaders
pcattori
changed the title
data and parentsData types from loadersMetaFunction type infers data and parentsData types from loaders
pcattori
force-pushed
the
pedro/infer-metafunction-data-and-parentsdata-from-loaders
branch
from
8a46f3d
to
60b10a3
Compare
chaance
approved these changes
Aug 19, 2022
|
@pcattori could you add some docs on this in the MetaFunction docs? |
pcattori
force-pushed
the
pedro/infer-metafunction-data-and-parentsdata-from-loaders
branch
from
60b10a3
to
591895a
Compare
pcattori
deleted the
pedro/infer-metafunction-data-and-parentsdata-from-loaders
branch
MichaelDeBoey
changed the title
MetaFunction type infers data and parentsData types from loadersMetaFunction type infers data and parentsData types from loaders
MichaelDeBoey
added
docs
package:server-runtime
awaiting release
This was referenced Aug 24, 2022
MichaelDeBoey
removed
the
awaiting release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #928
See usage example in new jsdoc for
MetaFunctionor in the changesetTesting Strategy: I tried out the example shown in the jsdoc locally