Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev): allow importing .csv files #3920

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

kayac-chang
Copy link
Contributor

@kayac-chang kayac-chang commented Aug 4, 2022

Discussion: #3919

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

🦋 Changeset detected

Latest commit: 792212c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 4, 2022

Hi @kayac-chang,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@kayac-chang kayac-chang changed the base branch from main to dev August 4, 2022 04:27
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 4, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title feat: 🎸 support import csv file, with file loader feat(remix-dev/compiler): import .csv files as file Aug 4, 2022
@MichaelDeBoey
Copy link
Member

@kayac-chang Could you please keep the map alphabetically?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Aug 4, 2022
@kayac-chang
Copy link
Contributor Author

@kayac-chang Could you please keep the map alphabetically?

roger

.changeset/wise-masks-sniff.md Show resolved Hide resolved
.changeset/wise-masks-sniff.md Show resolved Hide resolved
@kayac-chang
Copy link
Contributor Author

Hello, @MichaelDeBoey
I run yarn test on local environment,
I got three testing failed

`replace-remix-imports` migration › runs successfully
remix CLI › create prompts › allows you to go through the prompts and convert to JS
`convert-to-javascript` migration › runs successfully when ran programmatically

but I have no idea how to fixed that

@MichaelDeBoey
Copy link
Member

@kayac-chang All tests are passing both locally (macOS) & on CI
Only Windows has some "failing" tests, but this is due to timeouts

@kayac-chang
Copy link
Contributor Author

@kayac-chang All tests are passing both locally (macOS) & on CI Only Windows has some "failing" tests, but this is due to timeouts

Yeah🥳
Glad to heard that!!!
Is there anything I can help?

@MichaelDeBoey
Copy link
Member

@kayac-chang @mcansh is looking into the Windows failures in #3915, so we'll get there 👍

@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label Aug 25, 2022
@MichaelDeBoey MichaelDeBoey changed the title feat(remix-dev/compiler): import .csv files as file feat(remix-dev): allow importing .csv files Aug 25, 2022
@MichaelDeBoey
Copy link
Member

@kayac-chang Could you please look at the discussions I started?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Sep 3, 2022
@kayac-chang
Copy link
Contributor Author

needs-response

Sorry @MichaelDeBoey
Which discussion I need to response?

@kayac-chang
Copy link
Contributor Author

@MichaelDeBoey
sorry I missing your message.
I change the wise-masks-sniff.md to "@remix-run/dev": minor now.

@machour machour removed the needs-response We need a response from the original author about this issue/PR label Sep 8, 2022
.changeset/wise-masks-sniff.md Show resolved Hide resolved
.changeset/wise-masks-sniff.md Outdated Show resolved Hide resolved
@chaance chaance merged commit a292d12 into remix-run:dev Feb 9, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-ba4dba9-20230210 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@kayac-chang kayac-chang deleted the feat/support-import-csv-file branch February 20, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants