fix(remix-dev): support multiple nested pathless layout routes

[pokedotdev]

Closes: #3327

• Docs
• Tests

[remix-cla-bot]

Hi @pokedotdev,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1275481

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[apalumbo]

@MichaelDeBoey is this PR still to approve?

[brophdawg11]

Oh interesting, I didn't know we had a separate PR for this. This is also fixed by #4421 which was initially addressing #3014 but uncovered this same issue during testing. I think I lean towards the solution in #4421 since rather than mess with the id just to make it unique, we skip the check entirely for pathless layout routes which, by definition, create the potential for path collisions. I'll check with the team as well and we'll get one of these merged to fix #3327.

It may make sense to keep the integration tests from this PR even if we go with #4421 - I'll take a closer look and make sure we're properly covered.

[Vivalldi]

Noticed a small thing regarding the slug index & foo layout test

[chaance]

This got a bit outdated -- very sorry it took us a bit to follow up. As @brophdawg11 mentioned this should have been taken care of already, and most of the logic has been moved to React Router. If there is still an issue I'd suggest opening one in that repo so we can give it a fresh look.