fix(remix-eslint-config): update internal ESLint config (#4284)

remix-run · Dec 15, 2022 · faf0420 · faf0420
1 parent 28dcb62
commit faf0420
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -19,9 +19,8 @@ module.exports = {
     {
       files: ["templates/**/*.*"],
       rules: {
-        "prefer-const": WARN,
-
         "prefer-let/prefer-let": OFF,
+        "prefer-const": WARN,
       },
     },
   ],

diff --git a/packages/remix-eslint-config/internal.js b/packages/remix-eslint-config/internal.js
@@ -1,6 +1,6 @@
 /**
  * This config is intended for internal Remix projects. It should not be
- * documented nor considered public API in regards to semver considerations.
+ * documented nor considered public API in regard to semver considerations.
  */
 
 /**
@@ -13,6 +13,7 @@ const OFF = 0;
 const WARN = 1;
 const ERROR = 2;
 
+/** @type {import('eslint').Linter.Config} */
 module.exports = {
   root: true,
   extends: [
@@ -36,7 +37,8 @@ module.exports = {
       {
         "newlines-between": "always",
         groups: [
-          ["builtin", "external", "internal"],
+          ["builtin", "external"],
+          "internal",
           ["parent", "sibling", "index"],
         ],
       },

diff --git a/packages/remix-eslint-config/package.json b/packages/remix-eslint-config/package.json
@@ -43,14 +43,13 @@
   "devDependencies": {
     "@types/eslint": "^8.4.6",
     "eslint": "^8.23.1",
+    "jest": "^27.5.1",
     "react": "^18.2.0",
-    "react-dom": "^18.2.0",
     "typescript": "^4.7.4"
   },
   "peerDependencies": {
     "eslint": "^8.0.0",
     "react": "^17.0.0 || ^18.0.0",
-    "react-dom": "^17.0.0 || ^18.0.0",
     "typescript": "^4.0.0"
   },
   "peerDependenciesMeta": {