fix(dev): dev server creates cross-platform PATH envvar

remix-run · May 5, 2023 · d247cbb · d247cbb
1 parent f5ef1ac
commit d247cbb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/big-carrots-attend.md b/.changeset/big-carrots-attend.md
@@ -0,0 +1,6 @@
+---
+"@remix-run/dev": patch
+---
+
+normalize path for dev server PATH envvar
+so that it works cross-platform (e.g. windows)
diff --git a/packages/remix-dev/devServer_unstable/index.ts b/packages/remix-dev/devServer_unstable/index.ts
@@ -29,7 +29,7 @@ let detectBin = async (): Promise<string> => {
   if (pkgManager === "npm") {
     // npm v9 removed the `bin` command, so have to use `prefix`
     let { stdout } = await execa(pkgManager, ["prefix"]);
-    return stdout.trim() + "/node_modules/.bin";
+    return path.join(stdout.trim(), "node_modules", ".bin");
   }
   let { stdout } = await execa(pkgManager, ["bin"]);
   return stdout.trim();