fix: use file url for import to satisfy windows

remix-run · Aug 16, 2023 · a548b79 · a548b79
1 parent 58ff078
commit a548b79
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/integration/helpers/create-fixture.ts b/integration/helpers/create-fixture.ts
@@ -131,6 +131,7 @@ export async function createAppFixture(fixture: Fixture, mode?: ServerMode) {
         let rejectTimeout = setTimeout(() => {
           reject(new Error("Timed out waiting for remix-serve to start"));
         }, 20000);
+        serveProcess.stderr.pipe(process.stderr);
         serveProcess.stdout.on("data", (chunk) => {
           if (started) return;
           let newChunk = chunk.toString();

diff --git a/packages/remix-serve/cli.ts b/packages/remix-serve/cli.ts
@@ -1,6 +1,7 @@
 import "./env";
 import path from "node:path";
 import os from "node:os";
+import url from "node:url";
 import { broadcastDevReady, installGlobals } from "@remix-run/node";
 import sourceMapSupport from "source-map-support";
 
@@ -23,7 +24,10 @@ async function run() {
     process.exit(1);
   }
 
-  let buildPath = path.resolve(process.cwd(), buildPathArg);
+  let buildPath = url.pathToFileURL(
+    path.resolve(process.cwd(), buildPathArg)
+  ).href;
+
   let build = await import(buildPath);
 
   let onListen = () => {