fix: look for @remix-run/serve in devDependencies

remix-run · Apr 28, 2023 · 7b433f1 · 7b433f1
1 parent 39f6405
commit 7b433f1
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/.changeset/afraid-mice-remain.md b/.changeset/afraid-mice-remain.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": patch
+---
+
+look for @remix-run/serve in devDependencies when running remix dev
diff --git a/packages/remix-dev/cli/commands.ts b/packages/remix-dev/cli/commands.ts
@@ -540,7 +540,7 @@ let resolveDevServe = async (
     )}`;
 
     let usingRemixAppServer =
-      getAppDependencies(config)["@remix-run/serve"] !== undefined;
+      getAppDependencies(config, true)["@remix-run/serve"] !== undefined;
     if (!usingRemixAppServer) {
       console.error(
         [

diff --git a/packages/remix-dev/dependencies.ts b/packages/remix-dev/dependencies.ts
@@ -5,14 +5,27 @@ import type { RemixConfig } from "./config";
 
 type PackageDependencies = { [packageName: string]: string };
 
-function getPackageDependencies(packageJsonFile: string): PackageDependencies {
+function getPackageDependencies(
+  packageJsonFile: string,
+  includeDev?: boolean
+): PackageDependencies {
   let pkg = JSON.parse(fs.readFileSync(packageJsonFile, "utf8"));
-  return pkg?.dependencies || {};
+  let deps = pkg?.dependencies || {};
+
+  if (includeDev) {
+    Object.assign(deps, pkg?.devDependencies || {});
+  }
+
+  return deps;
 }
 
-export function getAppDependencies(config: RemixConfig): PackageDependencies {
+export function getAppDependencies(
+  config: RemixConfig,
+  includeDev?: boolean
+): PackageDependencies {
   return getPackageDependencies(
-    path.resolve(config.rootDirectory, "package.json")
+    path.resolve(config.rootDirectory, "package.json"),
+    includeDev
   );
 }